On Thu, Jun 11, 2020 at 11:30:17AM +0800, we...@ucloud.cn wrote: > From: wenxu <we...@ucloud.cn> > > Currently indr setup supoort both indr_setup_ft_cb and indr_setup_tc_cb. > But the __flow_block_indr_cleanup only check the indr_setup_tc_cb in > mlx5e driver. > It is better to just check the indr_release_cb, all the setup_cb type > share the same release_cb.
I think patch 1/2 and 2/2 should be collapsed into one single patch. (Non-native English) suggestion for your patch description: "If the representor is removed, then identify the indirect flow_blocks that need to be removed by the release callback." Thank you.
