On Mon, 2020-06-01 at 11:37 -0700, David Miller wrote: > From: Davide Caratti <dcara...@redhat.com> > Date: Fri, 29 May 2020 00:05:32 +0200 > > > trying to configure TC 'act_gate' rules with invalid control actions, the > > following splat can be observed: > > > > general protection fault, probably for non-canonical address > > 0xdffffc0000000002: 0000 [#1] SMP KASAN NOPTI > > KASAN: null-ptr-deref in range [0x0000000000000010-0x0000000000000017] > > CPU: 1 PID: 2143 Comm: tc Not tainted 5.7.0-rc6+ #168 > > Hardware name: Red Hat KVM, BIOS 1.11.1-4.module+el8.1.0+4066+0f1aadab > > 04/01/2014 > > RIP: 0010:hrtimer_active+0x56/0x290 > > [...] > > Call Trace: > > hrtimer_try_to_cancel+0x6d/0x330 > ... > > this is caused by hrtimer_cancel(), running before hrtimer_init(). Fix it > > ensuring to call hrtimer_cancel() only if clockid is valid, and the timer > > has been initialized. After fixing this splat, the same error path causes > > another problem: [...]
> Applied, thanks. hello Dave, for this patch I will probably need to send a follow-up, because the TC action overwrite case probably has still some issues [1] [2]. I can do that targeting the 'net' tree, unless Po or Cong have some objections. Ok? thank you in advance, -- davide [1] https://lore.kernel.org/netdev/cam_iqpvesoz0kq2owhss1kg3o5tvyuyetk4a3lw9doh5zfq...@mail.gmail.com/ [2] https://lore.kernel.org/netdev/696c630f8c72f2a6a0674b69921fd500f1d5d4d1.ca...@redhat.com/
