On Sat, May 30, 2020 at 01:54:51PM +0800, we...@ucloud.cn wrote:
> From: wenxu <we...@ucloud.cn>
>
> Currently add nat mangle action with comparing invert and ori tuple.
Nit, "orig" ---^
> It is better to check IPS_NAT_MASK flags first to avoid non necessary
> memcmp for non-NAT conntrack.
>
> Signed-off-by: wenxu <we...@ucloud.cn>
Acked-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com>
> ---
> net/sched/act_ct.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
> index 1a76639..2057735 100644
> --- a/net/sched/act_ct.c
> +++ b/net/sched/act_ct.c
> @@ -199,6 +199,9 @@ static int tcf_ct_flow_table_add_action_nat(struct net
> *net,
> const struct nf_conntrack_tuple *tuple = &ct->tuplehash[dir].tuple;
> struct nf_conntrack_tuple target;
>
> + if (!(ct->status & IPS_NAT_MASK))
> + return 0;
> +
> nf_ct_invert_tuple(&target, &ct->tuplehash[!dir].tuple);
>
> switch (tuple->src.l3num) {
> --
> 1.8.3.1
>
