On Fri, 2020-05-29 at 13:09 -0700, Jakub Kicinski wrote: > On Fri, 29 May 2020 12:46:39 -0700 Saeed Mahameed wrote: > > diff --git a/Documentation/networking/tls-offload.rst > > b/Documentation/networking/tls-offload.rst > > index f914e81fd3a64..44c4b19647746 100644 > > --- a/Documentation/networking/tls-offload.rst > > +++ b/Documentation/networking/tls-offload.rst > > @@ -428,6 +428,14 @@ by the driver: > > which were part of a TLS stream. > > * ``rx_tls_decrypted_bytes`` - number of TLS payload bytes in RX > > packets > > which were successfully decrypted. > > + * ``rx_tls_ctx`` - number of TLS RX HW offload contexts added to > > device for > > + decryption. > > + * ``rx_tls_ooo`` - number of RX packets which were part of a TLS > > stream > > + but did not arrive in the expected order and triggered the > > resync procedure. > > + * ``rx_tls_del`` - number of TLS RX HW offload contexts deleted > > from device > > + (connection has finished). > > + * ``rx_tls_err`` - number of RX packets which were part of a TLS > > stream > > + but were not decrypted due to unexpected error in the state > > machine. > > * ``tx_tls_encrypted_packets`` - number of TX packets passed to > > the device > > for encryption of their TLS payload. > > * ``tx_tls_encrypted_bytes`` - number of TLS payload bytes in TX > > packets > > Stack already has stats for some of these in /proc/net/tls_stat. > Does this really need to be per device?
these are great for debug.. IMHO stats for offloaded flows per device are nice thing to have ..