On 5/28/20 1:04 AM, Andrii Nakryiko wrote:
>> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
>> index 5d60de6fd818..493909d5d3d3 100644
>> --- a/tools/lib/bpf/libbpf.c
>> +++ b/tools/lib/bpf/libbpf.c
>> @@ -6657,6 +6657,8 @@ static const struct bpf_sec_def section_defs[] = {
>> .expected_attach_type = BPF_TRACE_ITER,
>> .is_attach_btf = true,
>> .attach_fn = attach_iter),
>> + BPF_EAPROG_SEC("xdp_dm", BPF_PROG_TYPE_XDP,
>> + BPF_XDP_DEVMAP),
>
> naming is hard and subjective, but does "dm" really associate with
> DEVMAP to you, rather than "direct message" or "direct memory" or
Yes it does b/c of the XDP context. Program name lengths being limited
to 15 characters makes me shorten all prefixes to leave some usable
characters for id'ing the program.
> something along those line? Is there any harm to call this
> "xdp_devmap"? It's still short enough, IMO.
>
but for the SEC name, I switched it to xdp_devmap.
