On Thu, 28 May 2020 at 19:21, Jakub Kicinski <k...@kernel.org> wrote: > > On Thu, 28 May 2020 02:41:04 +0300 Vladimir Oltean wrote: > > From: Vladimir Oltean <vladimir.olt...@nxp.com> > > > > This is not being used by any other module except ocelot (i.e. felix > > does not use it). So remove the EXPORT_SYMBOL. > > > > Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com> > > --- > > drivers/net/ethernet/mscc/ocelot.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/mscc/ocelot.c > > b/drivers/net/ethernet/mscc/ocelot.c > > index e621c4c3ee86..ff875c2f1d46 100644 > > --- a/drivers/net/ethernet/mscc/ocelot.c > > +++ b/drivers/net/ethernet/mscc/ocelot.c > > @@ -2152,7 +2152,6 @@ int ocelot_probe_port(struct ocelot *ocelot, u8 port, > > > > return err; > > } > > -EXPORT_SYMBOL(ocelot_probe_port); > > > > /* Configure and enable the CPU port module, which is a set of queues. > > * If @npi contains a valid port index, the CPU port module is connected > > Strangely I get an error after this patch: > > ERROR: modpost: "ocelot_probe_port" > [drivers/net/ethernet/mscc/ocelot_board.ko] undefined! make[2]: *** > [__modpost] Error 1 make[1]: *** [modules] Error 2 > make: *** [sub-make] Error 2 > > Maybe a build system error, could you double check?
Oh, I keep forgetting that CONFIG_MSCC_OCELOT_SWITCH and CONFIG_MSCC_OCELOT_SWITCH_OCELOT are different modules.... Ok, so moving ocelot_probe_port to ocelot_board.c needs a bit more work, I guess I'll just skip this patch for now.
