czw., 28 maj 2020 o 15:29 Mark Brown <broo...@kernel.org> napisał(a): > > On Thu, May 28, 2020 at 02:34:58PM +0200, Bartosz Golaszewski wrote: > > > This adds three new macros for simple bit operations: set_bits, > > clear_bits and test_bits. > > Why macros and not static inlines?
The existing regmap_update_bits_*() helpers are macros too, so I tried to stay consistent. Any reason why they are macros and not static inlines? If there's none, then why not convert them too? Otherwise we'd have a static inline expanding a macro which in turn is calling a function (regmap_update_bits_base()). Bartosz
