From: Ivan Vecera <ivec...@redhat.com>
Date: Wed, 27 May 2020 09:24:51 +0200
> On Wed, 27 May 2020 02:04:26 +0200
> Davide Caratti <dcara...@redhat.com> wrote:
>
>> this command hangs forever:
>>
>> # tc qdisc add dev eth0 root fq_pie flows 65536
>>
>> watchdog: BUG: soft lockup - CPU#1 stuck for 23s! [tc:1028]
...
>>
>> we can't accept 65536 as a valid number for 'nflows', because the loop on
>> 'idx' in fq_pie_init() will never end. The extack message is correct, but
>> it doesn't say that 0 is not a valid number for 'flows': while at it, fix
>> this also. Add a tdc selftest to check correct validation of 'flows'.
>>
>> CC: Ivan Vecera <ivec...@redhat.com>
>> Fixes: ec97ecf1ebe4 ("net: sched: add Flow Queue PIE packet scheduler")
>> Signed-off-by: Davide Caratti <dcara...@redhat.com>
...
> Good catch, Davide.
>
> Reviewed-by: Ivan Vecera <ivec...@redhat.com>
Applied and queued up for v5.6 -stable, thanks.
