On Tue, 26 May 2020 09:01:14 -0600 David Ahern wrote:
> From: David Ahern <[email protected]>
>
> Similar to the last path, need to fix fib_info_nh_uses_dev for
> external nexthops to avoid referencing multiple nh_grp structs.
> Move the device check in fib_info_nh_uses_dev to a helper and
> create a nexthop version that is called if the fib_info uses an
> external nexthop.
>
> Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
> Signed-off-by: David Ahern <[email protected]>
Dave, bunch of white space problems here according to checkpatch:
CHECK: Alignment should match open parenthesis
#31: FILE: include/net/ip_fib.h:451:
+static inline bool nhc_l3mdev_matches_dev(const struct fib_nh_common *nhc,
+const struct net_device *dev)
WARNING: suspect code indent for conditional statements (8, 24)
#33: FILE: include/net/ip_fib.h:453:
+ if (nhc->nhc_dev == dev ||
[...]
+ return true;
ERROR: code indent should use tabs where possible
#66: FILE: include/net/nexthop.h:284:
+ }$
WARNING: please, no spaces at the start of a line
#66: FILE: include/net/nexthop.h:284:
+ }$
ERROR: code indent should use tabs where possible
#67: FILE: include/net/nexthop.h:285:
+ } else {$
WARNING: please, no spaces at the start of a line
#67: FILE: include/net/nexthop.h:285:
+ } else {$
ERROR: code indent should use tabs where possible
#71: FILE: include/net/nexthop.h:289:
+ }$
WARNING: please, no spaces at the start of a line
#71: FILE: include/net/nexthop.h:289:
+ }$
total: 3 errors, 4 warnings, 1 checks, 74 lines checked
