Re: [RFC PATCH net-next 2/3] net: sched: sch_red: Split init and change callbacks

[Jakub Kicinski]

On Tue, 26 May 2020 20:10:06 +0300 Petr Machata wrote:
> +static int red_change(struct Qdisc *sch, struct nlattr *opt,
> +                   struct netlink_ext_ack *extack)
> +{
> +     struct red_sched_data *q = qdisc_priv(sch);

net/sched/sch_red.c: In function red_change:
net/sched/sch_red.c:337:25: warning: unused variable q [-Wunused-variable]
  337 |  struct red_sched_data *q = qdisc_priv(sch);
      |                         ^

Needs to go to the next patch.

> +     struct nlattr *tb[TCA_RED_MAX + 1];
> +     int err;
> +
> +     if (!opt)
> +             return -EINVAL;
> +
> +     err = nla_parse_nested_deprecated(tb, TCA_RED_MAX, opt, red_policy,
> +                                       extack);
> +     if (err < 0)
> +             return err;
> +
> +     return __red_change(sch, tb, extack);
>  }