> -----Original Message----- > From: Jakub Kicinski <[email protected]> > Sent: Friday, May 22, 2020 1:00 AM > To: Kiyanovski, Arthur <[email protected]> > Cc: [email protected]; [email protected]; Woodhouse, David > <[email protected]>; Machulsky, Zorik <[email protected]>; > Matushevsky, Alexander <[email protected]>; Bshara, Saeed > <[email protected]>; Wilson, Matt <[email protected]>; Liguori, Anthony > <[email protected]>; Bshara, Nafea <[email protected]>; Tzalik, Guy > <[email protected]>; Belgazal, Netanel <[email protected]>; Saidi, Ali > <[email protected]>; Herrenschmidt, Benjamin <[email protected]>; > Dagan, Noam <[email protected]>; Agroskin, Shay > <[email protected]>; Jubran, Samih <[email protected]> > Subject: RE: [PATCH V1 net-next 05/15] net: ena: add prints to > failed commands > > > > On Thu, 21 May 2020 22:08:24 +0300 [email protected] wrote: > > diff --git a/drivers/net/ethernet/amazon/ena/ena_eth_com.c > > b/drivers/net/ethernet/amazon/ena/ena_eth_com.c > > index a014f514c069..f0b90e1551a3 100644 > > --- a/drivers/net/ethernet/amazon/ena/ena_eth_com.c > > +++ b/drivers/net/ethernet/amazon/ena/ena_eth_com.c > > @@ -175,8 +175,10 @@ static int ena_com_close_bounce_buffer(struct > ena_com_io_sq *io_sq) > > if (pkt_ctrl->idx) { > > rc = ena_com_write_bounce_buffer_to_dev(io_sq, > > > > pkt_ctrl->curr_bounce_buf); > > - if (unlikely(rc)) > > + if (unlikely(rc)) { > > + pr_err("failed to write bounce buffer to > > + device\n"); > > Could you use dev_err() or even better netdev_err() to give users an idea > which > device is misbehaving? > > > return rc; > > + } > > > > pkt_ctrl->curr_bounce_buf = > > > > ena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);
Yes, you're right, that would be better. I'll remove this patch from the patchset, rework it, and submit it again in a future patchset. Thanks!
