> -----Original Message-----
> From: Jakub Kicinski <k...@kernel.org>
> Sent: Friday, May 22, 2020 1:00 AM
> To: Kiyanovski, Arthur <akiy...@amazon.com>
> Cc: da...@davemloft.net; netdev@vger.kernel.org; Woodhouse, David
> <d...@amazon.co.uk>; Machulsky, Zorik <zo...@amazon.com>;
> Matushevsky, Alexander <ma...@amazon.com>; Bshara, Saeed
> <sae...@amazon.com>; Wilson, Matt <m...@amazon.com>; Liguori, Anthony
> <aligu...@amazon.com>; Bshara, Nafea <na...@amazon.com>; Tzalik, Guy
> <gtza...@amazon.com>; Belgazal, Netanel <neta...@amazon.com>; Saidi, Ali
> <alisa...@amazon.com>; Herrenschmidt, Benjamin <b...@amazon.com>;
> Dagan, Noam <nda...@amazon.com>; Agroskin, Shay
> <shay...@amazon.com>; Jubran, Samih <same...@amazon.com>
> Subject: RE: [PATCH V1 net-next 05/15] net: ena: add prints to
> failed commands
>
>
>
> On Thu, 21 May 2020 22:08:24 +0300 akiy...@amazon.com wrote:
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_eth_com.c
> > b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
> > index a014f514c069..f0b90e1551a3 100644
> > --- a/drivers/net/ethernet/amazon/ena/ena_eth_com.c
> > +++ b/drivers/net/ethernet/amazon/ena/ena_eth_com.c
> > @@ -175,8 +175,10 @@ static int ena_com_close_bounce_buffer(struct
> ena_com_io_sq *io_sq)
> > if (pkt_ctrl->idx) {
> > rc = ena_com_write_bounce_buffer_to_dev(io_sq,
> >
> > pkt_ctrl->curr_bounce_buf);
> > - if (unlikely(rc))
> > + if (unlikely(rc)) {
> > + pr_err("failed to write bounce buffer to
> > + device\n");
>
> Could you use dev_err() or even better netdev_err() to give users an idea
> which
> device is misbehaving?
>
> > return rc;
> > + }
> >
> > pkt_ctrl->curr_bounce_buf =
> >
> > ena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl);
Yes, you're right, that would be better.
I'll remove this patch from the patchset, rework it, and submit it again in a
future patchset.
Thanks!
