> -----Original Message-----
> From: Jakub Kicinski <[email protected]>
> Sent: Thursday, May 21, 2020 09:23
> To: Kirsher, Jeffrey T <[email protected]>
> Cc: [email protected]; Guedes, Andre <[email protected]>;
> [email protected]; [email protected]; [email protected];
> Brown, Aaron F <[email protected]>
> Subject: Re: [net-next 03/15] igc: Add support for source address filters in 
> core
> 
> On Thu, 21 May 2020 00:27:46 -0700 Jeff Kirsher wrote:
> >  /**
> >   * igc_del_mac_filter() - Delete MAC address filter
> >   * @adapter: Pointer to adapter where the filter should be deleted from
> > + * #type: MAC address filter type (source or destination)
> 
> @ here^ otherwise:
> 
> drivers/net/ethernet/intel/igc/igc_main.c:2282: warning: Function parameter or
> member 'type' not described in 'igc_del_mac_filter'
> 
[Kirsher, Jeffrey T] 

I will get that cleaned up.  

> >   * @addr: MAC address
> >   *
> >   * Return: 0 in case of success, negative errno code otherwise.
> >   */
> > -int igc_del_mac_filter(struct igc_adapter *adapter, const u8 *addr)
> > +int igc_del_mac_filter(struct igc_adapter *adapter,
> > +                  enum igc_mac_filter_type type, const u8 *addr)

Reply via email to