Hi Jakub, Quoting Jakub Kicinski (2020-05-19 19:00:26) > On Tue, 19 May 2020 17:04:05 -0700 Jeff Kirsher wrote: > > This series contains updates to igc only. > > > > Sasha cleans up the igc driver code that is not used or needed. > > > > Vitaly cleans up driver code that was used to support Virtualization on > > a device that is not supported by igc, so remove the dead code. > > > > Andre renames a few macros to align with register and field names > > described in the data sheet. Also adds the VLAN Priority Queue Fliter > > and EType Queue Filter registers to the list of registers dumped by > > igc_get_regs(). Added additional debug messages and updated return codes > > for unsupported features. Refactored the VLAN priority filtering code to > > move the core logic into igc_main.c. Cleaned up duplicate code and > > useless code. > > No automated warnings :) > > It's a little strange how both TCI and ETYPE filters take the queue ID. > Looking at the code it's not immediately clear which one take > precedence. Can I install two rules for the same TCI and different ETYPE > or vice versa?
Although the driver currently accepts such rules, they don't work as expected (as you probably noticed already). Jeff has already a patch in his queue fixing this issue. And just clarifying, ETYPE filters precede VLAN priority filters. Regards, Andre
