On Wed, 20 May 2020 at 18:57, Jakub Kicinski <k...@kernel.org> wrote: > > On Wed, 20 May 2020 11:47:30 +0200 Björn Töpel wrote: > > From: Magnus Karlsson <magnus.karls...@intel.com> > > > > Move the AF_XDP zero-copy driver interface to its own include file > > called xdp_sock_drv.h. This, hopefully, will make it more clear for > > NIC driver implementors to know what functions to use for zero-copy > > support. > > > > Signed-off-by: Magnus Karlsson <magnus.karls...@intel.com> > > With W=1: > > net/xdp/xsk_queue.c:67:26: warning: symbol 'xsk_reuseq_prepare' was not > declared. Should it be static? > net/xdp/xsk_queue.c:86:26: warning: symbol 'xsk_reuseq_swap' was not > declared. Should it be static? > net/xdp/xsk_queue.c:108:6: warning: symbol 'xsk_reuseq_free' was not > declared. Should it be static? > net/xdp/xsk_queue.c:67:27: warning: no previous prototype for > xsk_reuseq_prepare [-Wmissing-prototypes] > 67 | struct xdp_umem_fq_reuse *xsk_reuseq_prepare(u32 nentries) > | ^~~~~~~~~~~~~~~~~~ > net/xdp/xsk_queue.c:86:27: warning: no previous prototype for xsk_reuseq_swap > [-Wmissing-prototypes] > 86 | struct xdp_umem_fq_reuse *xsk_reuseq_swap(struct xdp_umem *umem, > | ^~~~~~~~~~~~~~~ > net/xdp/xsk_queue.c:108:6: warning: no previous prototype for xsk_reuseq_free > [-Wmissing-prototypes] > 108 | void xsk_reuseq_free(struct xdp_umem_fq_reuse *rq) > | ^~~~~~~~~~~~~~~
Yes, missing include there. After the series these functions are removed, but still good to get rid of the (bisect) noise. I'll fix this in a v5. Thanks, Jakub! Björn
