On Wed, May 20, 2020 at 09:54:37AM -0300, Jason Gunthorpe wrote:
> > + if (!time) {
> > + dev_err(sdev->dev, "error: probe of virtbus dev %s timed out\n",
> > + name);
> > + virtbus_unregister_device(vdev);
>
> Unregister does kfree? In general I've found that to be a bad idea,
> many drivers need to free up resources after unregistering from their
> subsystem.
oops, never mind, this is the driver side it makes some sense - but
I'm not sure you should call it during error unwind anyhow. See above
about the wait being kind of bonkers..
Jason
