On Tue, May 19, 2020 at 06:23:35PM +0100, Edward Cree wrote: > On 19/05/2020 18:19, Pablo Neira Ayuso wrote: > > This is breaking netfilter again. > > Still waiting for you to explain what this "breaks". AFAICT the > new DONT_CARE has exactly the same effect that the old DONT_CARE > did, so as long as netfilter is using DONT_CARE rather than (say) > a hard-coded 0, it should be fine.
Did you test your patch with netfilter? I don't think. Netfilter is a client of this flow offload API, you have to test that your core updates do not break any of existing clients. Please, do not make me think this is intentional. I am pretty sure your motivation is to help get things better.
