Re: [PATCH net-next 2/3] nfp: don't check lack of RX/TX channels

[Michal Kubecek]

On Fri, May 15, 2020 at 12:49:01PM -0700, Jakub Kicinski wrote:
> Core will now perform this check.
> 
> Signed-off-by: Jakub Kicinski <k...@kernel.org>

Reviewed-by: Michal Kubecek <mkube...@suse.cz>

> ---
>  drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c 
> b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> index a5aa3219d112..6eb9fb9a1814 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> @@ -1438,8 +1438,7 @@ static int nfp_net_set_channels(struct net_device 
> *netdev,
>       unsigned int total_rx, total_tx;
>  
>       /* Reject unsupported */
> -     if (!channel->combined_count ||
> -         channel->other_count != NFP_NET_NON_Q_VECTORS ||
> +     if (channel->other_count != NFP_NET_NON_Q_VECTORS ||
>           (channel->rx_count && channel->tx_count))
>               return -EINVAL;
>  
> -- 
> 2.25.4
>