> -----Original Message-----
> From: David Miller <da...@davemloft.net>
> Sent: Thursday, May 14, 2020 15:08
> To: k...@kernel.org
> Cc: Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com>; Lifshits, Vitaly
> <vitaly.lifsh...@intel.com>; netdev@vger.kernel.org; nhor...@redhat.com;
> sassm...@redhat.com; lkp <l...@intel.com>; dan.carpen...@oracle.com;
> Brown, Aaron F <aaron.f.br...@intel.com>
> Subject: Re: [net-next v2 3/9] igc: add support to eeprom, registers and link
> self-tests
>
> From: Jakub Kicinski <k...@kernel.org>
> Date: Thu, 14 May 2020 14:52:19 -0700
>
> > On Thu, 14 May 2020 14:31:11 -0700 Jeff Kirsher wrote:
> >> diff --git a/drivers/net/ethernet/intel/igc/igc_diag.c
> >> b/drivers/net/ethernet/intel/igc/igc_diag.c
> >> new file mode 100644
> >> index 000000000000..1c4536105e56
> >> --- /dev/null
> >> +++ b/drivers/net/ethernet/intel/igc/igc_diag.c
> >> @@ -0,0 +1,186 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> >> +/* Copyright (c) 2020 Intel Corporation */
> >> +
> >> +#include "igc.h"
> >> +#include "igc_diag.h"
> >> +
> >> +struct igc_reg_test reg_test[] = {
> >> + { IGC_FCAL, 1, PATTERN_TEST, 0xFFFFFFFF, 0xFFFFFFFF },
> >> + { IGC_FCAH, 1, PATTERN_TEST, 0x0000FFFF, 0xFFFFFFFF },
> >> + { IGC_FCT, 1, PATTERN_TEST, 0x0000FFFF, 0xFFFFFFFF },
> >> + { IGC_RDBAH(0), 4, PATTERN_TEST, 0xFFFFFFFF, 0xFFFFFFFF },
> >
> > drivers/net/ethernet/intel/igc/igc_diag.c:7:21: warning: symbol 'reg_test'
> > was
> not declared. Should it be static?
>
> Jeff, you might want to start checking this kind of stuff internally since
> Jakub is
> going to catch it within minutes of you posting your changes :-)))
[Kirsher, Jeffrey T]
Ugh, I have been compile testing. Since moving to Fedora 32, kernel compiles
are now littered with warnings that were not showing up on the older GCC
version which is no excuse, I need to work on parsing the logs better.
