> From: Luis Chamberlain <mcg...@kernel.org> > Sent: Friday, May 8, 2020 9:36 PM > To: j...@kernel.org > Cc: a...@linux-foundation.org; a...@arndb.de; rost...@goodmis.org; > mi...@redhat.com; aqu...@redhat.com; c...@lca.pw; dyo...@redhat.com; > b...@redhat.com; pet...@infradead.org; t...@linutronix.de; > gpicc...@canonical.com; pmla...@suse.com; ti...@suse.de; > sch...@suse.de; andriy.shevche...@linux.intel.com; > keesc...@chromium.org; daniel.vet...@ffwll.ch; w...@kernel.org; > mchehab+sams...@kernel.org; kv...@codeaurora.org; > da...@davemloft.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Luis Chamberlain <mcg...@kernel.org>; Derek > Chickles <dchick...@marvell.com>; Satananda Burla <sbu...@marvell.com>; > Felix Manlunas <fmanlu...@marvell.com> > Subject: [PATCH 06/15] liquidio: use new module_firmware_crashed() > > ---------------------------------------------------------------------- > This makes use of the new module_firmware_crashed() to help annotate > when firmware for device drivers crash. When firmware crashes devices can > sometimes become unresponsive, and recovery sometimes requires a driver > unload / reload and in the worst cases a reboot. > > Using a taint flag allows us to annotate when this happens clearly. > > Cc: Derek Chickles <dchick...@marvell.com> > Cc: Satanand Burla <sbu...@marvell.com> > Cc: Felix Manlunas <fmanlu...@marvell.com> > Signed-off-by: Luis Chamberlain <mcg...@kernel.org> > --- > drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c > b/drivers/net/ethernet/cavium/liquidio/lio_main.c > index 66d31c018c7e..f18085262982 100644 > --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c > +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c > @@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param) > continue; > > WRITE_ONCE(oct->cores_crashed, true); > + module_firmware_crashed(); > other_oct = get_other_octeon_device(oct); > if (other_oct) > WRITE_ONCE(other_oct->cores_crashed, true); > -- > 2.25.1
Thanks! Reviewed-by: Derek Chickles <dchick...@marvell.com>