On 02/21, Stephen Hemminger wrote: > > This is what I was suggesting by getting rid of the work queue completely.
Can't comment this patch, but if we can get rid of the work_struct - good! > -static void port_carrier_check(struct work_struct *work) > +void br_port_carrier_check(struct net_bridge_port *p) > { > - struct net_bridge_port *p; > - struct net_device *dev; > - struct net_bridge *br; > - > - dev = container_of(work, struct net_bridge_port, > - carrier_check.work)->dev; > - work_release(work); May I ask you to redo this patch on top of [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR http://marc.theaimsgroup.com/?l=linux-kernel&m=117183517612775 ? We are removing the _NAR stuff, it would be nice to do this in a separate patch. Thanks! Oleg. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html