From: Maciej Żenczykowski <m...@google.com> This makes 'ping' 'ping6' and icmp based traceroute no longer require any suid or file capabilities.
These sockets have baked long enough that the restriction to make them unusable by default is no longer necessary. The concerns were around exploits. However there are now major distros that default to enabling this. This is already the default on Fedora 31: [root@f31vm ~]# cat /proc/sys/net/ipv4/ping_group_range 0 2147483647 [root@f31vm ~]# cat /usr/lib/sysctl.d/50-default.conf | egrep -B6 ping_group_range # ping(8) without CAP_NET_ADMIN and CAP_NET_RAW # The upper limit is set to 2^31-1. Values greater than that get rejected by # the kernel because of this definition in linux/include/net/ping.h: # #define GID_T_MAX (((gid_t)~0U) >> 1) # That's not so bad because values between 2^31 and 2^32-1 are reserved on # systemd-based systems anyway: https://systemd.io/UIDS-GIDS.html#summary -net.ipv4.ping_group_range = 0 2147483647 And in general is super useful for any network namespace container based setup. See for example: https://docs.docker.com/engine/security/rootless/ This is one less thing you need to configure when you creare a new network namespace. Before: vm:~# unshare -n vm:~# cat /proc/sys/net/ipv4/ping_group_range 1 0 After: vm:~# unshare -n vm:~# cat /proc/sys/net/ipv4/ping_group_range 0 2147483647 Signed-off-by: Maciej Żenczykowski <m...@google.com> --- net/ipv4/af_inet.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index cf58e29cf746..1a8cb6f3ee38 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -1819,12 +1819,8 @@ static __net_init int inet_init_net(struct net *net) net->ipv4.ip_local_ports.range[1] = 60999; seqlock_init(&net->ipv4.ping_group_range.lock); - /* - * Sane defaults - nobody may create ping sockets. - * Boot scripts should set this to distro-specific group. - */ - net->ipv4.ping_group_range.range[0] = make_kgid(&init_user_ns, 1); - net->ipv4.ping_group_range.range[1] = make_kgid(&init_user_ns, 0); + net->ipv4.ping_group_range.range[0] = GLOBAL_ROOT_GID; + net->ipv4.ping_group_range.range[1] = KGIDT_INIT(0x7FFFFFFF); /* Default values for sysctl-controlled parameters. * We set them here, in case sysctl is not compiled. -- 2.26.2.645.ge9eca65c58-goog
