On Mon, May 04, 2020 at 08:30:09AM +0300, Leon Romanovsky wrote: > + flow_act->action &= > + ~MLX5_FLOW_CONTEXT_ACTION_FWD_NEXT_PRIO; > + flow_act->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; > + handle = _mlx5_add_flow_rules(ft, spec, flow_act, dest, num_dest); > + if (IS_ERR_OR_NULL(handle)) > + goto unlock;
I never like seeing IS_ERR_OR_NULL().. In this case I see callers of mlx5_add_flow_rules() that crash if it returns NULL, so this can't be right. Also, I don't see an obvious place where _mlx5_add_flow_rules() returns NULL, does it? Jason
