>> Thats why the logic below randomizes only low three octets.
> 
> Are there any other drivers in tree which do that? I think the standard
> operating procedure is:
> 
> if (!valid) {
>       netdev_warn(dev, "Invalid MAC using random\n");
>       eth_hw_addr_random(dev);
> }
> 
> Please see all the eth_hw_addr_random() calls in drivers.

You are right indeed. Sorry I somehow overlooked this sequence in other device
drivers. Agree, its better to unify behavior then.

Thanks,
  Igor

Reply via email to