On Thu, May 07, 2020 at 03:59:09PM +0100, Edward Cree wrote: > Make FLOW_ACTION_HW_STATS_DONT_CARE be all bits, rather than none, so that > drivers and __flow_action_hw_stats_check can use simple bitwise checks.
You have have to explain why this makes sense in terms of semantics. _DISABLED and _ANY are contradicting each other. > In mlxsw we check for DISABLED first, because we'd rather save the counter > resources in the DONT_CARE case. And this also is breaking netfilter again. > Signed-off-by: Edward Cree <ec...@solarflare.com> > --- > Compile tested only. > > drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 8 ++++---- > include/net/flow_offload.h | 8 ++++---- Turning DONT_CARE gives us nothing back at all.
