On Thursday 22 February 2007 11:32, David Miller wrote: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Thu, 22 Feb 2007 11:22:02 +0100 > > > rcv_wup and copied_seq should be next to rcv_nxt field, to lower number > > of active cache lines in hot paths. (tcp_rcv_established(), tcp_poll(), > > ...) > > Please fixup the assignment order in tcp_create_openreq_child() else > we'll get a new store buffer stall during socket creation :-)
OK :) I wonder if : newtp->snd_nxt = newtp->snd_una = newtp->snd_sml = treq->snt_isn + 1; is correct, since compiler will write snd_sml, then snd_una, and snd_nxt Maybe we should also reorder this too ? Eric - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
