On Tue, May 05, 2020 at 03:35:27PM -0700, Cong Wang wrote: > On Tue, May 5, 2020 at 3:27 PM Michal Kubecek <mkube...@suse.cz> wrote: > > On Tue, May 05, 2020 at 02:58:19PM -0700, Cong Wang wrote: > > > diff --git a/net/core/dev.c b/net/core/dev.c > > > index 522288177bbd..ece50ae346c3 100644 > > > --- a/net/core/dev.c > > > +++ b/net/core/dev.c > > > @@ -8907,7 +8907,7 @@ static void netdev_sync_lower_features(struct > > > net_device *upper, > > > netdev_dbg(upper, "Disabling feature %pNF on lower > > > dev %s.\n", > > > &feature, lower->name); > > > lower->wanted_features &= ~feature; > > > - netdev_update_features(lower); > > > + __netdev_update_features(lower); > > > > > > if (unlikely(lower->features & feature)) > > > netdev_WARN(upper, "failed to disable %pNF > > > on %s!\n", > > > > Wouldn't this mean that when we disable LRO on a bond manually with > > "ethtool -K", LRO will be also disabled on its slaves but no netlink > > notification for them would be sent to userspace? > > What netlink notification are you talking about?
There is ethtool notification sent by ethnl_netdev_event() and rtnetlink notification sent by rtnetlink_event(). Both are triggered by NETDEV_FEAT_CHANGE notifier so unless I missed something, when you suppress the notifier, there will be no netlink notifications to userspace. Michal > When we change features from top down, ->ndo_fix_features() > does the work, in bonding case, it is bond_fix_features(). > I see no netlink notification either in bond_compute_features() > or bond_fix_features(). > > Thanks.
