On Tue, May 05, 2020 at 02:18:19AM +0200, Andrew Lunn wrote: > The Marvell PHYs have a couple of different register sets for > performing cable tests. Page 7 provides the simplest to use. > > Signed-off-by: Andrew Lunn <and...@lunn.ch> > --- > drivers/net/phy/marvell.c | 202 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 202 insertions(+) > > diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c > index 7fc8e10c5f33..72afc67f7f35 100644 > --- a/drivers/net/phy/marvell.c > +++ b/drivers/net/phy/marvell.c > @@ -27,6 +27,7 @@ > #include <linux/module.h> > #include <linux/mii.h> > #include <linux/ethtool.h> > +#include <linux/ethtool_netlink.h> > #include <linux/phy.h> > #include <linux/marvell_phy.h> > #include <linux/bitfield.h> > @@ -35,6 +36,7 @@ > #include <linux/io.h> > #include <asm/irq.h> > #include <linux/uaccess.h> > +#include <uapi/linux/ethtool_netlink.h> > > #define MII_MARVELL_PHY_PAGE 22 > #define MII_MARVELL_COPPER_PAGE 0x00
This shouldn't be necessary, <linux/ethtool_netlink.h> includes the UAPI header. [...] > +static int mavell_vct7_cable_test_report_trans(int result) Typo: "mavell". Michal
