On Mon, 4 May 2020 at 15:04, Dejin Zheng <zhengdej...@gmail.com> wrote:
>
> the related system resources were not released when enetc_hw_alloc()
> return error in the enetc_pci_mdio_probe(), add iounmap() for error
> handling label "err_hw_alloc" to fix it.
>
> Fixes: 6517798dd3432a ("enetc: Make MDIO accessors more generic and export to
> include/linux/fsl")
> Cc: Andy Shevchenko <andy.shevche...@gmail.com>
> Signed-off-by: Dejin Zheng <zhengdej...@gmail.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.olt...@nxp.com>
> drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> index ebc635f8a4cc..15f37c5b8dc1 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> @@ -74,8 +74,8 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev,
> pci_disable_device(pdev);
> err_pci_enable:
> err_mdiobus_alloc:
> - iounmap(port_regs);
> err_hw_alloc:
> + iounmap(port_regs);
> err_ioremap:
> return err;
> }
> --
> 2.25.0
>
Thanks!
-Vladimir
