Seems the split of dwmac-intel didn't go well and on top of that new functionality in the driver has not been properly tested.
Patch 1 fixes a nasty kernel crash due to missed error handling. Patches 2 and 3 fix the incorrect split (clock and PCI bar handling). Patch 4 converts driver to use new PCI IRQ allocation API. The rest is a set of clean ups that may have been done in the initial submission. Series has been tested on couple of Elkhart Lake platforms with different behaviour of ethernet hardware. Changelog v3: - added the cover letter (David) - appended separate fix as a first patch - marked patches 2 and 3 with Fixes tag Andy Shevchenko (7): stmmac: intel: Fix kernel crash due to wrong error path stmmac: intel: Fix clock handling on error and remove paths stmmac: intel: Remove unnecessary loop for PCI BARs stmmac: intel: Convert to use pci_alloc_irq_vectors() API stmmac: intel: Eliminate useless conditions and variables stmmac: intel: Fix indentation to put on one line affected code stmmac: intel: Place object in the Makefile according to the order drivers/net/ethernet/stmicro/stmmac/Makefile | 4 +- .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 160 +++++++----------- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 4 +- .../net/ethernet/stmicro/stmmac/stmmac_pci.c | 5 - 4 files changed, 68 insertions(+), 105 deletions(-) -- 2.26.2
