On 4/30/20 3:22 AM, Benjamin Poirier wrote:
On 2020-04-29 08:12 -0700, Roopa Prabhu wrote:
On Mon, Apr 27, 2020 at 4:51 PM Benjamin Poirier
<bpoir...@cumulusnetworks.com> wrote:
Output the same names for vlan flags as the ones accepted in command input.
Signed-off-by: Benjamin Poirier <bpoir...@cumulusnetworks.com>
---
Benjamin, It's a good change, but this will break existing users ?.
Nikolay voiced the same concern. The current output looks like
ben@f3:~$ bridge vlan
port vlan ids
br0 None
tap0 1 PVID Egress Untagged
tap1 1 PVID Egress Untagged
docker0 1 PVID Egress Untagged
ben@f3:~$
"PVID Egress Untagged" look like 3 flags to me. Anything we can do to
improve it?
Put a "," after PVID ? :-)
The bigger problem is that "Egress Untagged" is also used as a flag in the json
output.
Anyone parsing that and looking at the flags would be broken. In addition
this has been described in many of HowTos and docs over the years.
I'd just drop this change.
Thanks,
Nik
