Hi,
> > > > +enum {
> > > > + ETHTOOL_A_CABLE_PAIR_0,
> > > > + ETHTOOL_A_CABLE_PAIR_1,
> > > > + ETHTOOL_A_CABLE_PAIR_2,
> > > > + ETHTOOL_A_CABLE_PAIR_3,
> > > > +};
> > >
> > > Do we really need this enum, couldn't we simply use a number (possibly
> > > with a sanity check of maximum value)?
> >
> > They are not strictly required. But it helps with consistence. Are the
> > pairs numbered 0, 1, 2, 3, or 1, 2, 3, 4?
>
> OK, I'm not strictly opposed to it, it just felt a bit weird.
Speaking of the pairs. What is PAIR_0 and what is PAIR_3? Maybe
it is specified somewhere in a standard, but IMHO an example for
a normal TP cable would help to prevent wild growth amongst the
PHY drivers and would help to provide consistent reporting towards
the user space.
-michael
