On Tue, 22 Oct 2019 19:09:40 -0700, Shannon Nelson wrote:
> On 10/22/19 6:22 PM, Andrew Lunn wrote:
> > On Tue, Oct 22, 2019 at 01:31:09PM -0700, Shannon Nelson wrote:
> >> Fix the initial interrupt coalesce usec-to-hw setting
> >> to actually be usec-to-hw.
> >>
> >> Fixes: 780eded34ccc ("ionic: report users coalesce request")
> >> Signed-off-by: Shannon Nelson <[email protected]>
> > Hi Shannon
> >
> > How bad is this? Should it be backported? If so, you should send it as
> > a separate patch for net.
>
> Well, it doesn't "break" anything, but it does end up initializing the
> coalesce value to 0, aka turns it off. The easy work-around is for the
> user to set a new value, then all is well. However, since v5.4 is
> intended as an LTS, this probably should get promoted into net. If
> there aren't many other comments, I'll likely turn this around tomorrow
> afternoon.
I think the commit in question only landed in net-next after the merge
window. Perhaps the larger problem with the coalescing could have been
fixed in net, but now I think it may be too late, no?
