Hi Jakub, On Tue, 22 Oct 2019 14:53:16 -0700 Jakub Kicinski <[email protected]> wrote:
> On Mon, 21 Oct 2019 12:01:57 +0200, Stefano Brivio wrote: > > From: Hillf Danton <[email protected]> > > > > syzbot found the following crash on: > > > The function in net core, register_netdevice(), may fail with vport's > > destruction callback either invoked or not. After commit 309b66970ee2, > > I've added the correct commit quote here, please heed checkpatch'es > warnings. I disregarded this warning as it looks redundant to me, given that the full commit quote is already given in the Fixes: tag below. In this specific case, I guess it doesn't really make a difference, but sometimes one needs to mention the same commit multiple times in the actual message, and while checkpatch would complain about every single instance, I think that providing the full quote for each of them isn't very useful and hinders readability. > > Reported-by: [email protected] > > Fixes: 309b66970ee2 ("net: openvswitch: do not free vport if > > register_netdevice() is failed.") > > Cc: Taehee Yoo <[email protected]> > > Cc: Greg Rose <[email protected]> > > Cc: Eric Dumazet <[email protected]> > > Cc: Marcelo Ricardo Leitner <[email protected]> > > Cc: Ying Xue <[email protected]> > > Cc: Andrey Konovalov <[email protected]> > > Signed-off-by: Hillf Danton <[email protected]> > > Acked-by: Pravin B Shelar <[email protected]> > > [sbrivio: this was sent to [email protected] and never made its way > > to netdev -- resending original patch] > > Signed-off-by: Stefano Brivio <[email protected]> > > --- > > This patch was sent to [email protected] and appeared on netdev > > only as Pravin replied to it, giving his Acked-by. I contacted the > > original author one month ago requesting to resend this to netdev, > > but didn't get an answer, so I'm now resending the original patch. > > Applied and queued for 4.14+, thanks! Thank you! -- Stefano
