On 10/19/2019 2:16 AM, Jakub Kicinski wrote: > On Fri, 18 Oct 2019 19:38:22 +0000, Saeed Mahameed wrote: >> From: Tariq Toukan <tar...@mellanox.com> >> >> Do not assume the crypto info is accessible during the >> connection lifetime. Save a copy of it in the private >> TX context. > > It should be around as long as the driver knows about the socket, no? >
The crypto info instance passed to the driver (as parameter in connection creation callback) might be modified/zeroed/reused, so the driver is expected to save its own copy, not just the pointer.