On Wed, Oct 16, 2019 at 6:21 AM Jakub Sitnicki <ja...@cloudflare.com> wrote:
>
> Make the compiler report a clear error when bpf_helpers_doc.py needs
> updating rather than rely on the fact that Clang fails to compile
> English:
>
> ../../../lib/bpf/bpf_helper_defs.h:2707:1: error: unknown type name
> 'Unrecognized'
> Unrecognized type 'struct bpf_inet_lookup', please add it to known types!
>
> Signed-off-by: Jakub Sitnicki <ja...@cloudflare.com>
> ---
> scripts/bpf_helpers_doc.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/bpf_helpers_doc.py b/scripts/bpf_helpers_doc.py
> index 7df9ce598ff9..08300bc024da 100755
> --- a/scripts/bpf_helpers_doc.py
> +++ b/scripts/bpf_helpers_doc.py
> @@ -489,7 +489,7 @@ class PrinterHelpers(Printer):
> if t in self.mapped_types:
> return self.mapped_types[t]
> print("")
> - print("Unrecognized type '%s', please add it to known types!" % t)
> + print("#error \"Unrecognized type '%s', please add it to known
> types!\"" % t)
My bad, this was intended to be printed to stderr, not to stdout
output. Can you please do a follow up patch turning this into eprint
instead?
This shouldn't be reported by Clang, rather by tool. And we should
ensure in libbpf's Makefile that bpf_helper_defs.h is deleted on
error. I'll do it a bit later, unless you'll beat me to it.
> sys.exit(1)
>
> seen_helpers = set()
> --
> 2.20.1
>
