>> +static inline int aq_ptp_tm_offset_ingress_get(struct aq_ptp_s *aq_ptp)
>> +{
>> + return atomic_read(&aq_ptp->offset_ingress);
>> +}
>
> inline should not be used in C files. Let the compiler decide.
Ok
>> + atomic_set(&aq_ptp->offset_egress, egress);
>> + atomic_set(&aq_ptp->offset_ingress, ingress);
>
> It seems odd you have wrappers for atomic_read, but not atomic_set. Do
> the wrappers actually add anything?
I think no, they are just naming sugar.
Will discuss internally and probably leave direct atomic_get|set
>> + if (next_head == ring->tail)
>> + return -1;
>
> ENOMEM?
Right.
>> +
>> + ring->buff[ring->head] = skb_get(skb);
>> + ring->head = next_head;
>> +
>> + return 0;
>> +}
>> +
>
> Andrew
Thanks for your review, Andrew!
Regards,
Igor
