On Fri, Oct 11, 2019 at 09:03:33PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <[email protected]> > > NET_VENDOR_BROADCOM is intended to control a kconfig menu only. > It should not have anything to do with code generation. > As such, it should not select DIMLIB for all drivers under > NET_VENDOR_BROADCOM. Instead each driver that needs DIMLIB should > select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET). > > Link: > https://lkml.kernel.org/r/[email protected]/ > > Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") > Reported-by: Geert Uytterhoeven <[email protected]> > Signed-off-by: Randy Dunlap <[email protected]> > Cc: Uwe Kleine-König <[email protected]> > Cc: Tal Gilboa <[email protected]> > Cc: Saeed Mahameed <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: "David S. Miller" <[email protected]> > Cc: Jakub Kicinski <[email protected]> > Cc: Doug Ledford <[email protected]> > Cc: Jason Gunthorpe <[email protected]> > Cc: Leon Romanovsky <[email protected]> > Cc: Or Gerlitz <[email protected]> > Cc: Sagi Grimberg <[email protected]> > --- > drivers/net/ethernet/broadcom/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >
Thanks, Reviewed-by: Leon Romanovsky <[email protected]>
