On Fri, Oct 11, 2019 at 09:03:33PM -0700, Randy Dunlap wrote: > From: Randy Dunlap <rdun...@infradead.org> > > NET_VENDOR_BROADCOM is intended to control a kconfig menu only. > It should not have anything to do with code generation. > As such, it should not select DIMLIB for all drivers under > NET_VENDOR_BROADCOM. Instead each driver that needs DIMLIB should > select it (being the symbols SYSTEMPORT, BNXT, and BCMGENET). > > Link: > https://lkml.kernel.org/r/alpine.deb.2.21.1907021810220.13...@ramsan.of.borg/ > > Fixes: 4f75da3666c0 ("linux/dim: Move implementation to .c files") > Reported-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Signed-off-by: Randy Dunlap <rdun...@infradead.org> > Cc: Uwe Kleine-König <u...@kleine-koenig.org> > Cc: Tal Gilboa <ta...@mellanox.com> > Cc: Saeed Mahameed <sae...@mellanox.com> > Cc: netdev@vger.kernel.org > Cc: linux-r...@vger.kernel.org > Cc: "David S. Miller" <da...@davemloft.net> > Cc: Jakub Kicinski <jakub.kicin...@netronome.com> > Cc: Doug Ledford <dledf...@redhat.com> > Cc: Jason Gunthorpe <j...@mellanox.com> > Cc: Leon Romanovsky <leo...@mellanox.com> > Cc: Or Gerlitz <ogerl...@mellanox.com> > Cc: Sagi Grimberg <s...@grimberg.me> > --- > drivers/net/ethernet/broadcom/Kconfig | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >
Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com>
