On 10/13/2019 1:29 PM, Marek Vasut wrote:
> On 10/13/19 10:15 PM, Heiner Kallweit wrote:
>> On 13.10.2019 21:34, Marek Vasut wrote:
>>> The KSZ8051 PHY and the KSZ8794/KSZ8795/KSZ8765 switch share exactly the
>>> same PHY ID. Since KSZ8051 is higher in the ksphy_driver[] list of PHYs
>>> in the micrel PHY driver, it is used even with the KSZ87xx switch. This
>>> is wrong, since the KSZ8051 configures registers of the PHY which are
>>> not present on the simplified KSZ87xx switch PHYs and misconfigures
>>> other registers of the KSZ87xx switch PHYs.
>>>
>>> Fortunatelly, it is possible to tell apart the KSZ8051 PHY from the
>>> KSZ87xx switch by checking the Basic Status register Bit 0, which is
>>> read-only and indicates presence of the Extended Capability Registers.
>>> The KSZ8051 PHY has those registers while the KSZ87xx switch does not.
>>>
>>> This patch implements simple check for the presence of this bit for
>>> both the KSZ8051 PHY and KSZ87xx switch, to let both use the correct
>>> PHY driver instance.
>>>
>>> Signed-off-by: Marek Vasut <ma...@denx.de>
>>> Cc: Andrew Lunn <and...@lunn.ch>
>>> Cc: David S. Miller <da...@davemloft.net>
>>> Cc: Florian Fainelli <f.faine...@gmail.com>
>>> Cc: George McCollister <george.mccollis...@gmail.com>
>>> Cc: Heiner Kallweit <hkallwe...@gmail.com>
>>> Cc: Sean Nyekjaer <sean.nyekj...@prevas.dk>
>>> Cc: Tristram Ha <tristram...@microchip.com>
>>> Cc: Woojung Huh <woojung....@microchip.com>
>>> Fixes: 9d162ed69f51 ("net: phy: micrel: add support for KSZ8795")
>>
>> The Fixes tag has to be the first one. And patch still misses
>> the "net" annotation. For an example just see other fix submissions
>> on the mailing list.
>
> The "net" annotation ? The net: tag is right there in the subject.
>
It is missing from within the [PATCH] part of the subject, so it should
be [PATCH net] for the net tree (bugfixes) or [PATCH net-next] for
features (broadly speaking). This is explained in the netdev-FAQ that
Heiner pointed out previously:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.rst#n94
--
Florian
