> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Jacob Keller > Sent: Thursday, September 26, 2019 11:11 AM > To: netdev@vger.kernel.org > Cc: Intel Wired LAN <intel-wired-...@lists.osuosl.org>; Kirsher, Jeffrey T > <jeffrey.t.kirs...@intel.com>; Keller, Jacob E <jacob.e.kel...@intel.com>; > Richard Cochran <richardcoch...@gmail.com>; Felipe Balbi > <felipe.ba...@linux.intel.com>; David S . Miller <da...@davemloft.net>; Hall, > Christopher S <christopher.s.h...@intel.com> > Subject: [net-next v3 2/7] net: reject PTP periodic output requests with > unsupported flags > > Commit 823eb2a3c4c7 ("PTP: add support for one-shot output") introduced > a new flag for the PTP periodic output request ioctl. This flag is not > currently supported by any driver. > > Fix all drivers which implement the periodic output request ioctl to > explicitly reject any request with flags they do not understand. This > ensures that the driver does not accidentally misinterpret the > PTP_PEROUT_ONE_SHOT flag, or any new flag introduced in the future. > > This is important for forward compatibility: if a new flag is > introduced, the driver should reject requests to enable the flag until > the driver has actually been modified to support the flag in question. > > Cc: Richard Cochran <richardcoch...@gmail.com> > Cc: Felipe Balbi <felipe.ba...@linux.intel.com> > Cc: David S. Miller <da...@davemloft.net> > Cc: Christopher Hall <christopher.s.h...@intel.com> > Signed-off-by: Jacob Keller <jacob.e.kel...@intel.com> > --- > drivers/net/ethernet/broadcom/tg3.c | 4 ++++ > drivers/net/ethernet/intel/igb/igb_ptp.c | 4 ++++ > drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c | 4 ++++ > drivers/net/ethernet/microchip/lan743x_ptp.c | 4 ++++ > drivers/net/ethernet/renesas/ravb_ptp.c | 4 ++++ > drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 4 ++++ > drivers/net/phy/dp83640.c | 3 +++ > 7 files changed, 27 insertions(+) >
For the igb sections... Tested-by: Aaron Brown <aaron.f.br...@intel.com>
