On Thu, 10 Oct 2019 10:07:04 +0200, Jiri Pirko wrote: > Thu, Oct 10, 2019 at 05:38:18AM CEST, jakub.kicin...@netronome.com wrote: > >On Wed, 9 Oct 2019 13:04:43 +0200, Jiri Pirko wrote: > >> From: Jiri Pirko <j...@mellanox.com> > >> > >> During health reporter operations, driver might want to fill-up > >> the extack message, so propagate extack down to the health reporter ops. > >> > >> Signed-off-by: Jiri Pirko <j...@mellanox.com> > > > >I wonder how useful this is for non-testing :( We'd probably expect most > >health reporters to have auto-recovery on and therefore they won't be > >able to depend on that extack.. > > That is probably true. But still, what is harm of carrying potential > error message to the user?
Not sure, it just makes the right thing to do non-obvious to someone implementing the API (below level 7 on Rusty's API Design Manifesto). But I don't feel too strongly about it.
