Mon, Oct 07, 2019 at 11:37:21PM CEST, [email protected] wrote:
>On 10/2/19 4:56 AM, Jiri Pirko wrote:
>> diff --git a/ip/iplink.c b/ip/iplink.c
>> index 212a088535da..e3f8a28fe94c 100644
>> --- a/ip/iplink.c
>> +++ b/ip/iplink.c
>> @@ -111,7 +111,9 @@ void iplink_usage(void)
>> "\n"
>> " ip link xstats type TYPE [ ARGS ]\n"
>> "\n"
>> - " ip link afstats [ dev DEVICE ]\n");
>> + " ip link afstats [ dev DEVICE ]\n"
>> + " ip link prop add dev DEVICE [ altname NAME .. ]\n"
>> + " ip link prop del dev DEVICE [ altname NAME .. ]\n");
>
>spell out 'property' here. The matches below on "prop" is fine, but the
>help can show the full name.
Okay.
>
>
>> +
>> + if (matches(*argv, "add") == 0) {
>> + req.n.nlmsg_flags |= NLM_F_EXCL | NLM_F_CREATE | NLM_F_APPEND;
>> + req.n.nlmsg_type = RTM_NEWLINKPROP;
>> + } else if (matches(*argv, "del") == 0) {
>> + req.n.nlmsg_flags |= RTM_DELLINK;
>
>RTM_DELLINK is a command not a netlink flag.
Will fix.