On Tue, 8 Oct 2019 16:13:59 +0200, Jiri Pirko wrote:
> Tue, Oct 08, 2019 at 03:56:14PM CEST, liuhang...@gmail.com wrote:
> >Before reading the team port list, we need to acquire the RCU read lock.
> >Also change list_for_each_entry() to list_for_each_entry_rcu().
> >
> >Fixes: 9ed68ca0d90b ("team: add ethtool get_link_ksettings")
> >Reported-by: Paolo Abeni <pab...@redhat.com>
> >Signed-off-by: Hangbin Liu <liuhang...@gmail.com>
> >Acked-by: Paolo Abeni <pab...@redhat.com>
>
> It is not strictly needed a since rtnl is taken, but similar list
> iteration in team is designed to work without rtnl dependency.
>
> Acked-by: Jiri Pirko <j...@mellanox.com>
IIUC this is a cosmetic change and non-RCU iteration seems to be used
in a few places in team.c. Can we get this reposted for net-next, and
without the Fixes tag? Please keep Jiri's Ack.
