On Wed, 9 Oct 2019 10:26:30 +0900, Christopher KOBAYASHI wrote: > Commit e2bcd8b0ce6ee3410665765db0d44dd8b7e3b348 to > net/appletalk/atalk_proc.c removed the success case, rendering > appletalk.ko inoperable. This one-liner restores correct operation. > > Signed-off-by: Christopher KOBAYASHI <ch...@disavowed.jp>
Thank you, the code looks correct! Could you improve the commit message a little bit? Could you add a Fixes tag and use the standard way of quoting commits? https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes Once done could you send the patch again indicating this is the second revision in the subject? https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format > diff --git a/net/appletalk/atalk_proc.c b/net/appletalk/atalk_proc.c > index 550c6ca007cc..9c1241292d1d 100644 > --- a/net/appletalk/atalk_proc.c > +++ b/net/appletalk/atalk_proc.c > @@ -229,6 +229,8 @@ int __init atalk_proc_init(void) > sizeof(struct aarp_iter_state), NULL)) > goto out; > > + return 0; > + > out: > remove_proc_subtree("atalk", init_net.proc_net); > return -ENOMEM;
