Hi, Vladimir Oltean <[email protected]> writes:
> Hi Vinicius, > > On Wed, 9 Oct 2019 at 02:19, Vinicius Costa Gomes > <[email protected]> wrote: >> >> When configuring a taprio instance if "flags" is not specified (or >> it's zero), taprio currently replies with an "Invalid argument" error. >> >> So, set the return value to zero after we are done with all the >> checks. >> >> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading") >> Signed-off-by: Vinicius Costa Gomes <[email protected]> >> --- > > You mean clockid, not flags, right? I do mean "flags", yeah. The case I was testing was something like this: $ tc qdisc replace dev $IFACE parent root handle 100 taprio \ num_tc 3 \ map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \ queues 1@0 1@1 2@2 \ base-time $BASE_TIME \ sched-entry S 01 300000 \ sched-entry S 02 300000 \ sched-entry S 04 400000 \ clockid CLOCK_TAI Cheers, -- Vinicius
