Herbert Xu writes: > > [NETFILTER]: Clear GSO bits for TCP reset packet > > The TCP reset packet is copied from the original. This > includes all the GSO bits which do not apply to the new > packet. So we should clear those bits. > > Spotted by Patrick McHardy. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Something like this is needed for all trees with GSO. > Actually it applies to TSO too although the effect there > is a bit harder to notice. > > Cheers, > -- > Visit Openswan at http://www.openswan.org/ > Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > -- > diff --git a/net/ipv4/netfilter/ipt_REJECT.c b/net/ipv4/netfilter/ipt_REJECT. > c > index a9eb363..80f739e 100644 > --- a/net/ipv4/netfilter/ipt_REJECT.c > +++ b/net/ipv4/netfilter/ipt_REJECT.c > @@ -80,6 +80,10 @@ static void send_reset(struct sk_buff *oldskb, int hook) > nskb->mark = 0; > skb_init_secmark(nskb); > > + skb_shinfo(nskb)->gso_size = 0; > + skb_shinfo(nskb)->gso_segs = 0; > + skb_shinfo(nskb)->gso_type = 0; > + > tcph = (struct tcphdr *)((u_int32_t*)nskb->nh.iph + nskb->nh.iph->ihl); > > /* Swap source and dest */
I picked up this patch and we ran the overnight stress tests that had been experiencing this problem against it. No problems so far, which based on past results probably means the problem has indeed been fixed. Thank you! -- Mike Accetta ECI Telecom Ltd. Data Networking Division (previously Laurel Networks) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
