Prashant Malani [mailto:[email protected]] > Sent: Thursday, October 03, 2019 5:10 AM > To: Hayes Wang > Cc: [email protected]; [email protected]; nic_swsd; Prashant > Malani > Subject: [PATCH net-next] r8152: Add identifier names for function pointers > > Checkpatch throws warnings for function pointer declarations which lack > identifier names. > > An example of such a warning is: > > WARNING: function definition argument 'struct r8152 *' should > also have an identifier name > 739: FILE: drivers/net/usb/r8152.c:739: > + void (*init)(struct r8152 *); > > So, fix those warnings by adding the identifier names. > > While we are at it, also fix a character limit violation which was > causing another checkpatch warning. > > Change-Id: Idec857ce2dc9592caf3173188be1660052c052ce > Signed-off-by: Prashant Malani <[email protected]> > Reviewed-by: Grant Grundler <[email protected]>
Acked-by: Hayes Wang <[email protected]> Best Regards, Hayes
