On Wed, 2019-10-02 at 13:29 -0400, Josh Hunt wrote:
> Prior to this change an application sending <= 1MSS worth of data and
> enabling UDP GSO would fail if the system had SW GSO enabled, but the
> same send would succeed if HW GSO offload is enabled. In addition to this
> inconsistency the error in the SW GSO case does not get back to the
> application if sending out of a real device so the user is unaware of this
> failure.
>
> With this change we only perform GSO if the # of segments is > 1 even
> if the application has enabled segmentation. I've also updated the
> relevant udpgso selftests.
>
> Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT")
> Signed-off-by: Josh Hunt <[email protected]>
> ---
> net/ipv4/udp.c | 11 +++++++----
> net/ipv6/udp.c | 11 +++++++----
> tools/testing/selftests/net/udpgso.c | 16 ++++------------
> 3 files changed, 18 insertions(+), 20 deletions(-)
Reviewed-by: Alexander Duyck <[email protected]>
