On Mon, Sep 30, 2019 at 11:52:21AM +0530, Vasundhara Volam wrote:
> If any of the param or info_get op returns error, dumpit cb is
> skipping to dump remaining params or info_get ops for all the
> drivers.
>
> Fix to not return if any of the param/info_get op returns error
> as not supported and continue to dump remaining information.
>
> v2: Modify the patch to return error, except for params/info_get
> op that return -EOPNOTSUPP as suggested by Andrew Lunn. Also, modify
> commit message to reflect the same.
>
> Cc: Andrew Lunn <[email protected]>
> Cc: Jiri Pirko <[email protected]>
> Cc: Michael Chan <[email protected]>
> Signed-off-by: Vasundhara Volam <[email protected]>
> ---
> net/core/devlink.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/core/devlink.c b/net/core/devlink.c
> index e48680e..f80151e 100644
> --- a/net/core/devlink.c
> +++ b/net/core/devlink.c
> @@ -3172,7 +3172,7 @@ static int devlink_nl_cmd_param_get_dumpit(struct
> sk_buff *msg,
> NETLINK_CB(cb->skb).portid,
> cb->nlh->nlmsg_seq,
> NLM_F_MULTI);
> - if (err) {
> + if (err && err != -EOPNOTSUPP) {
> mutex_unlock(&devlink->lock);
> goto out;
> }
and out: is
out:
mutex_unlock(&devlink_mutex);
cb->args[0] = idx;
return msg->len;
}
Jiri: Is the intention really to throw away the error?
Looking at the rest of devlink, all the other _get_dumpit() functions,
except health_reporter_dump_get_dumpit(), do discard any errors.
As for this patch
Reviewed-by: Andrew Lunn <[email protected]>
Andrew
