From: Vinicius Costa Gomes <vinicius.go...@intel.com>
Date: Mon, 23 Sep 2019 22:04:58 -0700
> When removing a cbs instance when offloading is enabled, the crash
> below can be observed.
>
> The problem happens because that when offloading is enabled, the cbs
> instance is not added to the list.
>
> Also, the current code doesn't handle correctly the case when offload
> is disabled without removing the qdisc: if the link speed changes the
> credit calculations will be wrong. When we create the cbs instance
> with offloading enabled, it's not added to the notification list, when
> later we disable offloading, it's not in the list, so link speed
> changes will not affect it.
>
> The solution for both issues is the same, add the cbs instance being
> created unconditionally to the global list, even if the link state
> notification isn't useful "right now".
>
> Crash log:
...
> Fixes: e0a7683 ("net/sched: cbs: fix port_rate miscalculation")
Please use 12 significant digits for SHA1 IDs in the future in Fixes:
tags.
> Signed-off-by: Vinicius Costa Gomes <vinicius.go...@intel.com>
Applied and queued up for -stable.
