On 9/16/19 7:00 AM, Andrea Claudi wrote: > This reduces stack usage, as asprintf allocates memory on the heap. > > This indirectly fixes a snprintf truncation warning (from gcc v9.2.1): > > bpf.c: In function ‘bpf_get_work_dir’: > bpf.c:784:49: warning: ‘snprintf’ output may be truncated before the last > format character [-Wformat-truncation=] > 784 | snprintf(bpf_wrk_dir, sizeof(bpf_wrk_dir), "%s/", mnt); > | ^ > bpf.c:784:2: note: ‘snprintf’ output between 2 and 4097 bytes into a > destination of size 4096 > 784 | snprintf(bpf_wrk_dir, sizeof(bpf_wrk_dir), "%s/", mnt); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Fixes: e42256699cac ("bpf: make tc's bpf loader generic and move into lib") > Signed-off-by: Andrea Claudi <acla...@redhat.com> > --- > lib/bpf.c | 155 ++++++++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 116 insertions(+), 39 deletions(-) >
applied to iproute2-next. Thanks